Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: sealed #467

Merged
merged 4 commits into from
Dec 27, 2023
Merged

feature: sealed #467

merged 4 commits into from
Dec 27, 2023

Conversation

prestwich
Copy link
Member

Moves Sealed and Sealable into alloy-primitives

Motivation

Commonly used across many potential networks and crates.

Solution

Make Sealed and Sealable primitives

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Dec 27, 2023
@prestwich prestwich self-assigned this Dec 27, 2023
mattsse
mattsse requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also want unseal(self) -> T

https://github.com/paradigmxyz/reth/blob/22a450822ea808f22309b6e266af679b804fc13e/crates/primitives/src/header.rs#L526-L529

crates/primitives/src/sealed.rs Outdated Show resolved Hide resolved
@prestwich prestwich merged commit 6dd9112 into main Dec 27, 2023
21 checks passed
@prestwich prestwich deleted the prestwich/sealed branch December 27, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@mattsse mattsse mattsse approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestwich @mattsse @DaniPopes