Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean the sealed #468

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix: clean the sealed #468

merged 2 commits into from
Dec 28, 2023

Conversation

prestwich
Copy link
Member

Motivation

I need to let Dani review before merging
I need to let Dani review before merging
I need to let Dani review before merging
I need to let Dani review before merging

Solution

Expand docs and move attrs below

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Dec 28, 2023
@prestwich prestwich self-assigned this Dec 28, 2023
DaniPopes
DaniPopes requested changes Dec 28, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to hit enter on the third review:

new_unchecked and into_parts are not separated by a space

@prestwich
Copy link
Member Author

🖖

@prestwich prestwich merged commit 3eff25f into main Dec 28, 2023
21 checks passed
@prestwich prestwich deleted the prestwich/clean branch December 28, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes