feat(json-abi): add full_signature

[BrennerSpear]

Motivation

I’m working on a ABI fragments database so we can fill in function and event data for contracts that haven’t been verified, but we having a matching ABI fragment for from another contract.

We’re going to have each row be unique based on the full_signature, which includes the name of each param, for events, whether the param is indexed or not, and for functions, the state mutability

In ethers.js, there is a fragment FormatTypes.full that can generate the full signature for you.

https://docs.ethers.org/v5/api/utils/abi/fragments/#fragments--output-formats

some maximally illustrative examples:
function batchSwapExactIn(tuple(address pool, uint256 tokenInParam, uint256 tokenOutParam, uint256 maxPrice)[] swaps, address tokenIn, address tokenOut, uint256 totalAmountIn, uint256 minTotalAmountOut) payable returns (uint256 totalAmountOut)

event SetupDirectDebit(address indexed debtor, address indexed receiver, tuple(uint256 amount, uint256 startTime, uint256 interval) info)

Solution

I've added a .full_signature() function to the Function and Event structs

PR Checklist

• Added Tests
• Added Documentation
• No Breaking changes

Notes

Functions already have signature_full that includes the output types. This is pretty close to full_signature as a name. Are we fine with that or do we need to think of a different name for full_signature?

I thought about trying to overload some of the functions instead of making additional functions prepended with full_, but I don’t think it’d make it any cleaner.

[DaniPopes]

LGTM. Thanks!

[yorhodes]

is this relevant? https://www.4byte.directory/