wip: recursion mitigations #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
prestwich/recursion-fix
branch
from
6075f03
to
56063ef
Compare
prestwich
commented
Jan 25, 2024
|
@DaniPopes I'm unsure the best way to fix the proptest |
Fixed in 0e9edd9 |
2 tasks
|
@prestwich anything else to be done here? Looks good enough to merge already |
|
Are we confident this resolves the issues? or do we think additional work is needed? |
|
I'd say so, in any case I would like to get this in for the next release. Further work can be in follow-ups. |
DaniPopes
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
discussion aid for ongoing work on #490
Solution
PR Checklist