Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signature): construct Signature bytes using v+27 when we do not have an EIP155 v #502

Closed
wants to merge 6 commits into from
Closed

fix(signature): construct Signature bytes using v+27 when we do not have an EIP155 v #502

wants to merge 6 commits into from

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Jan 25, 2024

Motivation

Followup for #499.

Solution

In the cases when we do not have an EIP155 v, construct the signature using y_parity_byte_non_eip155, to add 27 to v if necessary.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@Evalir Evalir closed this Jan 25, 2024
@Evalir Evalir deleted the evalir/construct-sig-bytes branch January 25, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Evalir