fix: Signature bincode serialization #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
reviewed
Feb 4, 2024
| @@ -92,6 +92,15 @@ impl Parity { | |||
| } | |||
| } | |||
|
|
|||
| /// Return the corresponding u64 V value. | |||
| pub const fn to_u64(&self) -> u64 { | |||
There was a problem hiding this comment.
should be a From/Into implementation?
There was a problem hiding this comment.
Could be, yes. To me it felt more like the y_parity_byte which is not a From<u8> either.
But I don't have a strong opinion at all, I can change it to a From. Whatever you prefer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current way the serialization/deserialization of
Signatureis implemented only works for human readable (JSON) formats. However, binary formats likebincodethat do not supportDeserializer::deserialize_identifierare not supported.Solution
Similar to #221, this PR uses the
is_human_readable()flag to distinguish between using the current serialization (SerializeMap) or abincodecompatible version.For this, the serialization is implemented as a tuple
(r: U256, s: U256, v: u64).