Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support function overloading in sol! #53

Merged
merged 3 commits into from
Jun 3, 2023
Merged

feat: support function overloading in sol! #53

merged 3 commits into from
Jun 3, 2023

Conversation

DaniPopes
Copy link
Member

No description provided.

@DaniPopes DaniPopes requested a review from prestwich May 22, 2023 11:37
prestwich
prestwich reviewed Jun 1, 2023
View reviewed changes
crates/sol-macro/src/input.rs
}
}
panic!(

let msg = format!(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consider using graph traversal to detect cycles and resolve dependency chains

@DaniPopes DaniPopes merged commit 7b2d45a into main Jun 3, 2023
@DaniPopes DaniPopes deleted the dani/sol-overloads branch June 3, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich