feat: derive Allocative on FixedBytes #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
DaniPopes,
prestwich and
gakonst
as code owners
onbjerg
approved these changes
Feb 19, 2024
|
Fails on 1.65 because it has higher MSRV |
|
@Rjected do you want to add it to more types? |
I do, as many as possible |
|
Yep this will improve profiling on Reth |
|
@DaniPopes I think this is good for now, will open another PR when I get around to bytes stuff |
prestwich
reviewed
Feb 27, 2024
| @@ -16,8 +16,15 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| rust: ["stable", "beta", "nightly", "1.65"] # MSRV | |||
| rust: ["stable", "beta", "nightly"] | |||
There was a problem hiding this comment.
are we updating our MSRV policy?
There was a problem hiding this comment.
No, just not testing --all-features because this feature requires a higher MSRV
DaniPopes
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Recently I was introduced to https://github.com/facebookexperimental/allocative, which seems promising as an easy way to collect granular information about certain data structures' memory usage in reth.
Solution
Introduce the
allocativefeature intoprimitives, and to start, derive theAllocativetrait on FixedBytes. I can derive this on the rest of the types later.PR Checklist