fix(dyn-abi): enable DynSolType.coerce_json to convert array of numbers to bytes
#541
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce_json_simple()to handle case where input value is an array of numbers instead of a string
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the course of implementing dynamic EIP-712 typed data signing on the alloy repo, I encountered an issue (see this comment) where
bytesare being encoded as an array of numbers byTypedData::from_struct, causing an error wheneip712_signing_hash()is called on the returned value:TypeMismatch { expected: "bytes", actual: "[102,105,122,122]" }.@prestwich suggested the code (see comment) that is contained in this PR in order to resolve the issue.
Solution
add logic to the
bytes()function used inDynSolType.coerce_json_simple()to handle case where theinputvalue is an array of numbers instead of a string.PR Checklist