Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TxKind #542

Merged
merged 4 commits into from
Feb 28, 2024
Merged

feat: add TxKind #542

merged 4 commits into from
Feb 28, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented Feb 27, 2024

This type started causing a circular dependency in alloy-rs/alloy#190, so I opted to move it to the primitives crate

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich
Copy link
Member

approved for concept ACK but need to go proper no-std

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as james

@onbjerg
Copy link
Member Author

onbjerg commented Feb 27, 2024

@mattsse how did we solve this lint in reth?

@DaniPopes DaniPopes merged commit 90e800e into main Feb 28, 2024
21 checks passed
@DaniPopes DaniPopes deleted the onbjerg/txkind branch February 28, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants