Prestwich/dyn sol error #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
force-pushed
the
prestwich/dyn-sol-error
branch
from
ba94758
to
5a2e00e
Compare
Evalir
reviewed
Mar 2, 2024
DaniPopes
requested changes
Mar 2, 2024
| /// Error selector. | ||
| pub(crate) selector: Selector, | ||
| /// Error body types. | ||
| pub(crate) body: DynSolType, |
There was a problem hiding this comment.
DynSolEvent uses DynSolType for body. could change both?
There was a problem hiding this comment.
i'd rather leave as-is for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Work on bringing dyn-abi up to feature parity with sol-types
Solution
Add
DynSolErrorto matchDynSolTypeandDynSolEventPR Checklist