Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force clippy to stable #569

Merged
merged 2 commits into from
Mar 17, 2024
Merged

fix: force clippy to stable #569

merged 2 commits into from
Mar 17, 2024

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Mar 13, 2024

Motivation

Prevent future random CI breakage

closes #566

Solution

Set clippy to stable in CI

there may be a better way to achieve this, but this way is straightforward

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Mar 13, 2024
@prestwich prestwich self-assigned this Mar 13, 2024
@prestwich prestwich marked this pull request as ready for review March 13, 2024 20:38
@prestwich prestwich requested a review from mattsse March 15, 2024 16:00
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds reasonable to me.
no more false positive unstable issues

wdyt @DaniPopes

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this

@prestwich prestwich merged commit f1666fb into main Mar 17, 2024
21 checks passed
@prestwich prestwich deleted the prestwich/stable-clippy branch March 17, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Use stable clippy instead of nightly
3 participants