fix(dyn-abi): correctly parse uints in coerce_str
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using
coerce_strto parse a uint from a decimal number in non-wei units, precision is lost due to use off64. For example, parsing123456.123456789123456789 etherreturns123456123456789126578176wei, but the correct value is123456123456789123456789wei.Solution
I removed uses of
f64, and all math is now done usingU256only. This also meansstdis no longer required when parsing decimal numbers withcoerce_str.I also added test cases that fail without this change.
PR Checklist