-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: break SolInput to its own crate #578
Conversation
bd57d37
to
68ad52d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have enough context for why this is beneficial, but it sounds reasonable to me
pending @DaniPopes
#[cfg(feature = "json")] | ||
mod json; | ||
|
||
extern crate syn_solidity as ast; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move above mods?
incremental progress towards reusing the same input for multiple procmacros. Basically, this would allow us to ingest the input (solidity + i.e. We could separate the sol interface macro expansion logic, from the rpc bindings macro expansion logic, and then compose those expanders. Much cleaner macro architecture, long-term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
supportive
Motivation
Closes #567
Decompose
sol!
macro and allow reuse of input across multiple expandersSolution
SolInput
and relatedExpander
traitfollowup #579
PR Checklist