Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sol-macro): don't double attributes in JSON input #583

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix(sol-macro): don't double attributes in JSON input #583

merged 2 commits into from
Mar 22, 2024

Conversation

DaniPopes
Copy link
Member 

error: unexpected attribute
  --> crates/evm/core/src/abi/hardhat_console.rs:10:5
   |
10 |     #[derive(ConsoleFmt)]
   |     ^^^^^^^^^^^^^^^^^^^^^

@DaniPopes DaniPopes merged commit ff33969 into main Mar 22, 2024
21 checks passed
@DaniPopes DaniPopes deleted the dani/sol-fix-json-attrs branch March 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich prestwich approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @prestwich @mattsse