-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearranged type param order so that the Network param is the last #587
Conversation
@onbjerg Thanks for your advice in alloy-rs/alloy#356 (comment). I've opened this PR to adjust the type param order in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense,
does this introduce more issues with patched alloy-core deps on alloy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this currently clashes with alloy-provider, no?
so this is a alloy-provider issue first
EDIT: I should read the PR more closely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I made the generated struct also default to N = Ethereum
. Will merge once companion PR alloy-rs/alloy#356 is ready.
@DaniPopes Thanks! I've just fixed alloy-rs/alloy#356 and it's ready now. Once this PR is merged, I'll update alloy dependencies to use the latest alloy-core |
Motivation
To default Network parameters to Ethereum in
alloy-provider
andalloy-contract
, they need to be moved to the last of the type params: alloy-rs/alloy#356According to those changes, we need to adjust the type param order in
sol!
as well.from: alloy-rs/alloy#263
Solution
PR Checklist