-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: sol!
AST and macro expansion
#61
Conversation
bc8f9ee
to
c38175e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's take this opportunity to document our parser's relationship to the grammar, for future reference
also to consider:
|
Probably yes, in the future, same for the traits. Would be too much for this PR and we don't need it yet |
e201d3a
to
23c38df
Compare
let's open an issue for it :) |
23c38df
to
e5f98ed
Compare
Decouple expansion logic from the AST.
ast
item
(previousinput
)Struct
Error
ToTokens
implementations, but as separate functionsAdditionally, refactor attributes parsing into doing the same as
syn
(parse attributes before parsing anItem
, then append them into the item's).Input -> SingleInput -> InputKind
becomesFile -> Item
.