feature: DynSolCall #632
Merged
feature: DynSolCall #632
+218
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyone know what's up with miri cancelling? |
prestwich
force-pushed
the
prestwich/dyn-func
branch
from
201fc7c
to
c33ce32
Compare
DaniPopes
requested changes
Jun 4, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
prestwich
force-pushed
the
prestwich/dyn-func
branch
from
3fa8151
to
2c3457f
Compare
DaniPopes
approved these changes
Jun 18, 2024
klkvr
pushed a commit
that referenced
this pull request
Aug 4, 2024
* feature: DynSolCall * lint: clippy * Update crates/dyn-abi/src/eip712/mod.rs Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * fix: revert crates/dyn-abi/src/ext/abi.rs --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Continue fleshing out dyn-abi to reach feature parity with sol-types
Solution
DynSolCallDynSolReturnsimpl Specifier<DynSolCall> for FunctionPR Checklist