Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix dep job, add feature-checks job #64

Merged
merged 1 commit into from
Jun 4, 2023
Merged

ci: fix dep job, add feature-checks job #64

merged 1 commit into from
Jun 4, 2023

Conversation

DaniPopes
Copy link
Member

  • bytes always has extern crate alloc so there is no point in gating that
  • deps workflow is outdated, since there is no Cargo.lock so it would never run

mattsse
mattsse approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestwich prestwich merged commit 1d48666 into main Jun 4, 2023
@DaniPopes DaniPopes deleted the dani/ci-features branch June 4, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @prestwich @mattsse