Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(primitives): Signed formatting #643

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix(primitives): Signed formatting #643

merged 1 commit into from
Jun 4, 2024
+15 −15

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jun 4, 2024 •
edited
Loading

sign_plus flag ({:+}) would get printed twice as now Uint also formats it. Only this flag is affected which is pretty rare.

@DaniPopes DaniPopes merged commit d523ac1 into main Jun 4, 2024
30 checks passed
@DaniPopes DaniPopes deleted the dani/fix-signed-formatting branch June 4, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich Awaiting requested review from prestwich

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DaniPopes