Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sol-macro): add return value names to simple getters #648

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

DaniPopes
Copy link
Member

Example:

sol! {
    contract Counter {
        uint256 public number;
    }
}

// Before:
Counter::numberReturn { _0: U256 }
// After:
Counter::numberReturn { number: U256 }

See the added test

@DaniPopes DaniPopes requested a review from prestwich as a code owner June 4, 2024 18:00
@DaniPopes DaniPopes force-pushed the dani/sol-getter-return-names branch from bf8785a to 715ef63 Compare June 4, 2024 18:24
@DaniPopes
Copy link
Member Author

This mismatches Solc-emitted ABI because it does not populate return names

@DaniPopes DaniPopes merged commit 8baa2fd into main Jun 4, 2024
30 checks passed
@DaniPopes DaniPopes deleted the dani/sol-getter-return-names branch June 4, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants