Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): derive Arbitrary for Signature #652

Merged
merged 1 commit into from
Jun 10, 2024
Merged

feat(primitives): derive Arbitrary for Signature #652

merged 1 commit into from
Jun 10, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

Needed for alloy-rs/alloy#109.

primitive Signature and Parity types do not derive Arbitrary. But the Transaction type in alloy requires it.

Solution

Derive Arbitrary for the test and arbitrary feature.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya
Copy link
Member Author

@DaniPopes @prestwich merge pls

@mattsse mattsse merged commit d467a78 into alloy-rs:main Jun 10, 2024
30 checks passed
@DaniPopes
Copy link
Member

What about proptest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @DaniPopes @mattsse