fix: small fixes for DynSolValue strategies
#683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Jul 4, 2024
klkvr
added a commit
that referenced
this pull request
Aug 4, 2024
* fix: arbitrary for integer types * better strategies for custom types * rm regressions * rm newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
adjust_integerwas always zeroing out top-most256 - sizebits, thus resulting in incorrect values in some cases. Example forint8case:-1 & ((1 << 8) - 1) = 255which overflows int8. This PR changes it to correctly handle sign and set higher bits to 1 in cases when we end up with a negative value.CustomStructwere generating duplicating field names in certain cases, also value strategy forCustomStructtypes was generating different field names for every instance.Solution
PR Checklist