feat: add EncodableSignature trait #692
Closed
+149
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mattsse
reviewed
Jul 24, 2024
There was a problem hiding this comment.
this seems like an appropriate solution to our problem, but I wonder could we introduce this trait in the alloy crate instead first?
everything that's required by this trait should be available via public API and could be implemented on the exported Signature type I believe?
|
Done in alloy-rs/alloy#1100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per @mattsse comment: #689 (comment)
To give more context: the goal is to standardize signature encoding via an helper trait to be able to use alloy tx types in reth with reth signature type.
Solution
PR Checklist