Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve macros #7

Merged
merged 4 commits into from
Apr 19, 2023
Merged

feat: improve macros #7

merged 4 commits into from
Apr 19, 2023

Conversation

DaniPopes
Copy link
Member

Do more stuff at compile time

DaniPopes
DaniPopes commented Apr 19, 2023
View reviewed changes
abi/src/coder/token.rs Outdated Show resolved Hide resolved
prestwich
prestwich reviewed Apr 19, 2023
View reviewed changes
abi/sol-type-parser/src/struct.rs Outdated Show resolved Hide resolved
abi/sol-type-parser/src/struct.rs Outdated Show resolved Hide resolved
abi/sol-type-parser/src/struct.rs Outdated Show resolved Hide resolved
abi/sol-type-parser/src/struct.rs
"{}({}){}", Self::NAME, types.join(","),
tails.join("")
)
fn encode_type() -> Cow<'static, str> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change ty

abi/src/sol_types/sol_type.rs
type TokenType: TokenType;

/// The name of the type in solidity
fn sol_type_name() -> RustString;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good change

prestwich
prestwich requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep the tuple impls at 20 to match current ethers behavior

@prestwich prestwich added the enhancement New feature or request label Apr 19, 2023
@prestwich
Copy link
Member

Doc tests broken as well

test src/sol_types/sol_type.rs - sol_types::sol_type::SolType (line 49) ... FAILED
test src/sol_types/sol_type.rs - sol_types::sol_type::SolType (line 23) ... FAILED
test src/lib.rs - (line 72) ... FAILED

@prestwich prestwich merged commit 8f0592b into main Apr 19, 2023
@DaniPopes DaniPopes deleted the dani/improve-macros branch April 25, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees

@DaniPopes DaniPopes

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich