Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ethereum_ssz dependency #701

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

eserilev
Copy link
Contributor

Motivation

Lighthouse is currently migrating our code base and relevant dependencies to alloy_primtives. During the migration we've come across some circular dependency issues between the ethereum_ssz and alloy_primitives crates.

Solution

This PR aims to remove the optional ethereum_ssz dependency as well as the ssz feature flag.

I have an open PR here that implements ssz Decode and Encode for the alloy generic types Bytes and FixedBytes<N> in ethereum_ssz

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice,

in order to transition we need to coordinate releases,
we first need to merge this pr, then do a new alloy-core release, followed by an ssz release so we can also update all dependent crates.

so we can merge this once ethereum_ssz is also ready to publish

@michaelsproul
Copy link

How about this for a release strategy?

  1. Release ethereum_ssz v0.6 which depends on alloy-primitives 0.7.7
  2. Release alloy-primitives v0.8 which does not depend on ethereum_ssz at all
  3. Release ethereum_ssz v0.7 which depends on alloy-primitives v0.8

We can try to make the timing quite tight between (2) and (3). I will try to get (1) out ASAP.

@DaniPopes
Copy link
Member

Sounds good, although I'm not sure if you need (1), but up to you

@DaniPopes DaniPopes merged commit 2a0bfff into alloy-rs:main Aug 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants