Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: feature-gate getrandom, document in README.md #71

Merged
merged 2 commits into from
Jun 7, 2023
Merged

chore: feature-gate getrandom, document in README.md #71

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e293a
docs: document wasm32-unknown-unknown getrandom failures
DaniPopes Jun 7, 2023
e52d765
chore: feature-gate `getrandom`
DaniPopes Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,17 @@ contribution follows the linting rules and passes clippy.
We provide full support for all the `wasm*-*` targets. If any crate does not
build on a WASM target, please [open an issue].

When compiling for `wasm32-unknown-unknown`, compilation will fail on the
`getrandom` crate. This is expected; see [their documentation][getrandom] on
how to fix this and for more details.
DaniPopes marked this conversation as resolved.
Show resolved Hide resolved

There is currently no plan to provide an official JS/TS-accessible library
interface, as we believe [viem] or [ethers.js] serve that need very well.

[open an issue]: https://github.com/alloy-rs/core/issues/new
[getrandom]: https://docs.rs/getrandom/#webassembly-support
[viem]: https://viem.sh
[ethers.js]: https://docs.ethers.io/v6/
[open an issue]: https://github.com/alloy-rs/core/issues/new

## Note on `no_std`

Expand Down