Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump MSRV to 1.79 #712

Merged
merged 2 commits into from
Sep 5, 2024
Merged

chore: bump MSRV to 1.79 #712

merged 2 commits into from
Sep 5, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 21, 2024 •
edited
Loading

Increase MSRV from 1.65 to 1.79. In particular, this stabilized const {} blocks.

Waiting on 1.81 to be released to respect our MSRV policy.

Closes #724.

@DaniPopes DaniPopes mentioned this pull request Sep 5, 2024
Closed
@DaniPopes DaniPopes marked this pull request as ready for review September 5, 2024 20:04
@DaniPopes
Copy link
Member Author

Next bump will likely be 1.81 for core::error.

mattsse
mattsse approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending .81 bump

@DaniPopes DaniPopes merged commit 1ebee07 into main Sep 5, 2024
30 checks passed
@DaniPopes DaniPopes deleted the dani/msrv-bump-08 branch September 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Use derive_more 1.0
2 participants
@DaniPopes @mattsse