fix(parser): add no_std support for CustomError
#718
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements `core::error::Error` for `CustomError` when the `std` feature is not enabled. This change ensures compatibility with environments that do not support the standard library.
mattsse
reviewed
Sep 2, 2024
Comment on lines
+27
to
+28
| #[cfg(not(feature = "std"))] | ||
| impl core::error::Error for CustomError {} |
There was a problem hiding this comment.
this should be no_std already?
this isn't supported yet with the current msrv
There was a problem hiding this comment.
mb add https://crates.io/crates/rustversion macro here? (impl core::error::Error for rust 1.81+)
|
This breaks MSRV, and have another fix in #720 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #717.
Solution
impl core::error::Error for CustomErrorPR Checklist