Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Turn off derive_more default features #728

Closed
wants to merge 3 commits into from
Closed

fix: Turn off derive_more default features #728

wants to merge 3 commits into from

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Sep 6, 2024

Description

Turns off default-features for the derive_more dep to support no_std.

@refcell
Copy link
Contributor Author

refcell commented Sep 6, 2024

Fixing... Still need full feat flag

@refcell
Copy link
Contributor Author

refcell commented Sep 6, 2024

This now passes the no_std check. Can add to this pr to demonstrate

@refcell refcell mentioned this pull request Sep 6, 2024
Merged
@DaniPopes
Copy link
Member

sorry took over #727 pre-emptively

@DaniPopes DaniPopes closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refcell @DaniPopes @mattsse