Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse selector hashes in sol macro #730

Merged
merged 7 commits into from
Sep 6, 2024
Merged

fix: parse selector hashes in sol macro #730

merged 7 commits into from
Sep 6, 2024

Conversation

cre-mer
Copy link
Contributor

@cre-mer cre-mer commented Sep 6, 2024 •
edited by DaniPopes
Loading

Motivation and Solution

This PR fixes #729. It adds a check for duplicate function selector hashes when generating a contract's ABI.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

DaniPopes
DaniPopes approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added a test and made sure that it works within contracts.

@DaniPopes DaniPopes merged commit 83e70b7 into alloy-rs:main Sep 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Lack of selector checking in sol macro
2 participants
@cre-mer @DaniPopes