fix(sol-macro): namespaced custom type resolution #731
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently type resolution does not handle namespaces correctly, causing such example to fail:
When resolving
LibB.Nested
we'll enterLibA.A
type which containsB
struct. However, we don't set namespace toLibA
, and will instead try to resolveB
as item ofLibB
, which would fail.Solution
I've updated
resolve_custom_types
fn to use customResolver
visitor which keeps track of namespace, updates it before entering a type from another namespace and resets it to previous value after type is processed.PR Checklist