feat: support Keccak with sha3 #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
requested review from
DaniPopes,
prestwich and
gakonst
as code owners
|
Yo any update on this? |
onbjerg
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
lgtm impl wise, pending either @DaniPopes or @mattsse if we want this in
mattsse
reviewed
Sep 18, 2024
|
yeah they do produce the same hashes, both crates are impls of https://csrc.nist.gov/pubs/fips/202/final |
mattsse
reviewed
Sep 18, 2024
There was a problem hiding this comment.
not opposed to it, but defer to @DaniPopes
1 question about activated both feature gated hashers
DaniPopes
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature
sha3-keccaktoalloy-primitivesthat when enabled, usessha3for Keccak. This can be desirable as in some casessha3is faster.This feature is added in a completely backward-compatible way:
tiny-keccakis still the default, and downstream libs/apps will not suddenly start usingsha3by just doingcargo update.