-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom serialization for Address #742
Merged
DaniPopes
merged 3 commits into
alloy-rs:main
from
jenpaff:jenpaff/use-EIP-55-checksummed-address
Sep 20, 2024
Merged
Add custom serialization for Address #742
DaniPopes
merged 3 commits into
alloy-rs:main
from
jenpaff:jenpaff/use-EIP-55-checksummed-address
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @DaniPopes please correct me if I'm wrong Tip: for CI |
jenpaff
force-pushed
the
jenpaff/use-EIP-55-checksummed-address
branch
2 times, most recently
from
September 20, 2024 13:23
ba8dcb1
to
bc55d26
Compare
jenpaff
force-pushed
the
jenpaff/use-EIP-55-checksummed-address
branch
from
September 20, 2024 13:57
bc55d26
to
1352007
Compare
DaniPopes
reviewed
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nits
Address override in impl_serde!
is fine, I can't think of a better way to do this without having to restructure wrap_fixed_bytes!
.
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
zerosnacks
approved these changes
Sep 20, 2024
DaniPopes
approved these changes
Sep 20, 2024
DaniPopes
pushed a commit
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Partially closes foundry-rs/foundry#8715
We want to serialize Address type in checksum format.
Solution
Solution is to implement a custom serialization function for
Address
type.I ran into some issues:
The
impl_serde
macro conflicts withimpl Serialize for Address
(Address
is wrapped with thewrap_fixed_bytes
macro which callsimpl_serde
), so I added a workaround inimpl_serde
to bypassAddress
type. Another solution would be to just move the impl directly into the macro- if preferred.There's another type
EIP712Domain
which uses the typeAddress
, I wanted to double check that it is okay for this to also be serialized in checksum format, I added another unit test to make it explicit.PR Checklist