Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Arbitrary for Sealed<T> #762

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Derive Arbitrary for Sealed<T> #762

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7556ceb
Derive arbitrary for Sealed<T>
emhane Oct 4, 2024
89f495c
Manual impl Arbitrary for Sealed<T>
emhane Oct 4, 2024
e5febd9
Fix lint
emhane Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/primitives/src/sealed.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ use crate::B256;
/// implement the [`Sealable`] trait to provide define their own hash.
#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[cfg_attr(feature = "arbitrary", derive(derive_arbitrary::Arbitrary, proptest_derive::Arbitrary))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be problematic because this generates an arbitrary hash,
we should probably impl for T: Sealable and then seal?

pub struct Sealed<T> {
/// The inner item
inner: T,
Expand Down
Loading