Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alloy-sol-macro): allow clippy::pub_underscore_fields on sol! output #770

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix(alloy-sol-macro): allow clippy::pub_underscore_fields on sol! output #770

merged 1 commit into from
Oct 10, 2024

Conversation

benluelo
Copy link
Contributor

fixes #769, not sure if tests are required here - if they are, just let me know how I should add a test for this

DaniPopes
DaniPopes approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 7490294 into alloy-rs:main Oct 10, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] sol! should emit #[allow(clippy::pub_underscore_fields)]
2 participants
@benluelo @DaniPopes