Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly account for sign in pg to/from sql implementation for signed #772

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

luzzif
Copy link
Contributor

@luzzif luzzif commented Oct 12, 2024

Motivation

The FromSql/ToSql implementations for the Signed type didn't properly account for signs when dealing with the NUMERIC type. This PR addresses it. Check out the screenshot below for an example.

image

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit a7ad6d3 into alloy-rs:main Oct 13, 2024
29 checks passed
@luzzif
Copy link
Contributor Author

luzzif commented Oct 13, 2024

Any idea when we could see this integrated in the alloy Rust crate? Or alternatively, could you tell me how I can locally use this?

@DaniPopes
Copy link
Member

DaniPopes commented Oct 13, 2024

You can patch alloy-primitives in your workspace manifest until a new release is made: https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html

@DaniPopes
Copy link
Member

This is now released in 0.8.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants