chore: bump MSRV to 1.81 & use core::error::Error in place of std
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for the bump is to take advantage of the stabilization of `core::error::Error`, which subsequently removes quite a few `std` feature gates from the codebase.
Evalir
force-pushed
the
evalir/impl-error-core
branch
from
2597106
to
f3da7cf
Compare
3 tasks
|
Reverted, waiting to re-apply like in alloy-rs/alloy#1552 |
|
sounds good—1.83 should be out in exactly a month so we can include it then |
DaniPopes
added a commit
that referenced
this pull request
Oct 28, 2024
ZelionD
pushed a commit
to ZelionD/core
that referenced
this pull request
Nov 11, 2024
* Revert "chore: bump MSRV to 1.81 & use `core::error::Error` in place of `std` (alloy-rs#780)" This reverts commit 7b84276. * Revert "chore: address MSRV TODOs for 1.81 (alloy-rs#781)" This reverts commit d37a5aa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bumping the MSRV to 1.81 lets us use
core::error::Erroras it was finally added to the core library.The only places where a
stdfeature gate for errors was not removed, was becauseconst-hexand/orruintwould need to do this too. @DaniPopes wdyt?Solution
stdfeature gates for error impls, usecore::error::ErrorPR Checklist