Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DerefMut for Log<T> #786

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Implement DerefMut for Log<T> #786

merged 1 commit into from
Oct 25, 2024

Conversation

wtdcode
Copy link
Contributor

@wtdcode wtdcode commented Oct 25, 2024

Motivation

Following #775, this implements DerefMut for Log<T> so that the methods taking &mut self won't have compilation errors.

Thanks @mattsse for pointing out that, this can be workarounded by accessing log.data directly.

Solution

As above.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg onbjerg merged commit e715933 into alloy-rs:main Oct 25, 2024
29 checks passed
@yash-atreya yash-atreya mentioned this pull request Oct 25, 2024
Closed
ZelionD pushed a commit to ZelionD/core that referenced this pull request Nov 11, 2024
@wtdcode @ZelionD
Implement DerefMut for Log<T> (alloy-rs#786)
0defba1 
Implement DerefMut for Log<T>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@onbjerg onbjerg onbjerg approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wtdcode @onbjerg @DaniPopes