Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Signature with PrimitiveSignature #796

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 30, 2024

Motivation

ref #776

Removes Parity type and replaces Signature with PrimitiveSignature

This should go into next breaking release

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klkvr klkvr merged commit 9856a37 into main Oct 31, 2024
30 checks passed
@klkvr klkvr deleted the klkvr/replace-sig branch October 31, 2024 18:21
klkvr added a commit that referenced this pull request Oct 31, 2024
klkvr added a commit that referenced this pull request Oct 31, 2024
klkvr added a commit that referenced this pull request Oct 31, 2024
Revert "chore: replace Signature with PrimitiveSignature (#796)"

This reverts commit 9856a37.
ZelionD pushed a commit to ZelionD/core that referenced this pull request Nov 11, 2024
* chore: replace Signature with PrimitiveSignature

* fmt
ZelionD pushed a commit to ZelionD/core that referenced this pull request Nov 11, 2024
Revert "chore: replace Signature with PrimitiveSignature (alloy-rs#796)"

This reverts commit 9856a37.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants