Prestwich/events #87
Merged
Prestwich/events #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
approved these changes
Jun 9, 2023
DaniPopes
approved these changes
Jun 9, 2023
DaniPopes
pushed a commit
that referenced
this pull request
Jun 9, 2023
* fix: event trait fixes * fix: re-exporting event * refactor: event trait take 2 * refactor: improve topic detokenization * refactor: change events to account for indexed structs not in body * fix: move test to bottom of event
DaniPopes
added a commit
that referenced
this pull request
Jun 12, 2023
* chore: add tests, format attrs * feat: parse events * Prestwich/events (#87) * fix: event trait fixes * fix: re-exporting event * refactor: event trait take 2 * refactor: improve topic detokenization * refactor: change events to account for indexed structs not in body * fix: move test to bottom of event * name * chore: cleanup * docs * assign anon variables names in expansion * wip * refactor: implement `SolType` for `{Ui,I}nt<N>` and `FixedBytes<N>` with const-generics * chore: clippy * chore: add more trait bounds * clean up code * cleanups * finish EventTopic impls * fix: impl for empty tuple * chore: clippy * rm unsafe * review * Type only tuple variants, move is_dynamic methods to Type * chore: clippy * docs --------- Co-authored-by: James Prestwich <james@prestwi.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the event trait to match solidity's and the EVM's behavior
Based on #83, and should be merged into 83