Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate signature with boolean parity #12

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Oct 20, 2024

Motivation

See alloy-rs/alloy#1540 alloy-rs/core#776 for context

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klkvr klkvr changed the title [wip] integrate signature with boolean parity chore: integrate signature with boolean parity Oct 29, 2024
@klkvr klkvr changed the title chore: integrate signature with boolean parity feat: integrate signature with boolean parity Oct 29, 2024
@klkvr klkvr marked this pull request as ready for review October 29, 2024 18:41
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
we can hold off a release until we ready to do an alloy-primitives minor, then rename and also release this

@mattsse mattsse merged commit 499ca8e into main Oct 30, 2024
26 checks passed
@mattsse mattsse deleted the klkvr/bool-parity branch October 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants