fix: correctly handle v values #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
|
Note, this is likely a breaking change for the codec in Reth, meaning this would not work on Odyssey |
mattsse
reviewed
Oct 21, 2024
mattsse
requested changes
Oct 22, 2024
Comment on lines
+111
to
+112
| #[cfg_attr(feature = "serde", serde(rename = "yParity"))] | ||
| y_parity: U8, |
There was a problem hiding this comment.
let's add some context here that any U8 is valid but will be invalid for evm?
| #[cfg_attr(feature = "serde", serde(rename = "yParity"))] | ||
| y_parity: U8, | ||
| r: U256, | ||
| s: U256, |
There was a problem hiding this comment.
I order to write them to disk on reth we also need getters for all the fields
we need ensure that we can do:
mattsse
reviewed
Oct 22, 2024
crates/eip7702/src/auth_list.rs
Outdated
| } | ||
|
|
||
| /// Returns the signature parity value. | ||
| pub const fn y_parity(&self) -> U8 { |
There was a problem hiding this comment.
can we do u8 here so that the caller doesn't have to do this?
mattsse
approved these changes
Oct 22, 2024
crates/eip7702/src/auth_list.rs
Outdated
| pub const fn signature(&self) -> &Signature { | ||
| &self.signature | ||
| /// Creates a new signed authorization from raw signature values. | ||
| pub fn new_unchecked(inner: Authorization, y_parity: U8, r: U256, s: U256) -> Self { |
There was a problem hiding this comment.
Suggested change
| pub fn new_unchecked(inner: Authorization, y_parity: U8, r: U256, s: U256) -> Self { | |
| pub fn new_unchecked(inner: Authorization, y_parity: u8, r: U256, s: U256) -> Self { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For EIP-7702 authorization any
vvalue <2**8 is valid during decoding and should be attempted for recovery. During recovery, only 0 and 1 values should be accepted.Solution
This removes inner
signature: Signaturefield from authorization, replacing it with separate v, r, s fields.fn signaturenow returns a result of conversion of vrs to signaturePR Checklist