Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix CI issues #149

Merged
merged 6 commits into from
Oct 9, 2024
Merged

chore: fix CI issues #149

merged 6 commits into from
Oct 9, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Oct 9, 2024

@zerosnacks
Copy link
Member Author

zerosnacks commented Oct 9, 2024

There appears to be a regression in Anvil introduced in 57bcac09ef36e14655fc62691a021f588defd6fb (foundry-rs/foundry#9000)

It is related to legacy transactions and the Wallet / WalletFiller

cc @yash-atreya

Steps to reproduce:

  1. in foundry: git reset --hard 57bcac09ef36e14655fc62691a021f588defd6fb
  2. make build
  3. cd ../alloy-examples (alloy-examples at latest main)
  4. cp ../foundry/target/debug/anvil /home/<USER>/.foundry/bin/anvil
  5. cargo run --example send_legacy_transaction

throws

Running `target/debug/examples/send_legacy_transaction`
Error: server returned an error response: error code -32602: Failed to decode transaction

Location:
    examples/transactions/examples/send_legacy_transaction.rs:32:22

should run as of commit before it (08a6409ab742f33b398de0fb5bc6c24800677e8c)

Running `target/debug/examples/send_legacy_transaction`
Pending transaction... 0x43318079f461acf56b7c645e17559109495bb538f642bf8e5be867872acefb14
Transaction included in block 1

@zerosnacks
Copy link
Member Author

zerosnacks commented Oct 9, 2024

For future reference, checked with @yash-atreya

Looks like a fix will be included in the next Alloy release

Related: alloy-rs/alloy#1428 / #144 (comment)

@zerosnacks
Copy link
Member Author

Unblocking CI, added a follow-up check for me regarding the regression here: #150

@zerosnacks zerosnacks marked this pull request as ready for review October 9, 2024 14:50
@zerosnacks zerosnacks merged commit 6f4df4c into main Oct 9, 2024
5 checks passed
@zerosnacks zerosnacks deleted the zerosnacks/fix-ci-issues branch October 9, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant