Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement Encodable and Decodable for OpTxType #243

Open
ozgunozerk opened this issue Nov 11, 2024 · 0 comments
Open

[Feature] Implement Encodable and Decodable for OpTxType #243

ozgunozerk opened this issue Nov 11, 2024 · 0 comments
Labels
A-consensus Area: consensus crate

Comments

@ozgunozerk
Copy link

Component

consensus

Describe the feature you would like

Right now, OpTxType does not derive these.

And RlpEncodable and RlpDecodable cannot be used on enums.

Might be useful and easier for other projects that are using these. For example: paradigmxyz/reth#12443

Additional context

I can volunteer to take on this issue, however a bit of guidance and context would be appreciated.

Why RlpEncodable and RlpDecodable designed in a way that they only support structs but not enums?

Does it make sense to extend the supported set for these macros so that they can support enums? Or should we implement the Encodable and Decodable traits manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: consensus crate
Projects
None yet
Development

No branches or pull requests

2 participants