Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(op): define OpTxType #12443

Merged
merged 7 commits into from
Nov 12, 2024
Merged

feat(op): define OpTxType #12443

merged 7 commits into from
Nov 12, 2024

Conversation

ozgunozerk
Copy link
Contributor

Closes #12333

Added few notes on the code for the reviewer as discussion.

emhane
emhane requested changes Nov 11, 2024
View reviewed changes
crates/optimism/primitives/src/op_tx_type.rs Outdated Show resolved Hide resolved
crates/optimism/primitives/src/op_tx_type.rs Outdated Show resolved Hide resolved
crates/optimism/primitives/src/op_tx_type.rs Outdated Show resolved Hide resolved
crates/optimism/primitives/src/op_tx_type.rs Outdated Show resolved Hide resolved
crates/optimism/primitives/src/op_tx_type.rs Outdated Show resolved Hide resolved
@ozgunozerk ozgunozerk mentioned this pull request Nov 11, 2024
Open
@ozgunozerk
Copy link
Contributor Author

@emhane thanks a lot for your fast responses and great suggestions!

I think the last discussion point is, what type or error should be used.

After relaxing the trait bound as suggested:

agree, the trait bound TryFrom<u8, Error = Eip2718Error> should be relaxed to just TryFrom

I switched to alloy_rlp::Error, and used the custom variant.

If you are want any change w.r.t error handling, let me know :)

emhane
emhane approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! remaining merge conflicts

@Rjected Rjected changed the title optxtype feat: define OpTxType Nov 12, 2024
@Rjected Rjected changed the title feat: define OpTxType feat(op): define OpTxType Nov 12, 2024
@Rjected Rjected added C-enhancement New feature or request A-sdk Related to reth's use as a library A-op-reth Related to Optimism and op-reth labels Nov 12, 2024
@emhane emhane added this pull request to the merge queue Nov 12, 2024
@emhane emhane mentioned this pull request Nov 12, 2024
Merged
Merged via the queue into paradigmxyz:main with commit 5edca40 Nov 12, 2024
41 checks passed
@ozgunozerk ozgunozerk deleted the ozgun-optxtype branch November 12, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define OpTxType
3 participants
@ozgunozerk @Rjected @emhane