Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define OpTxType #12333

Closed
Tracked by #7649
emhane opened this issue Nov 5, 2024 · 3 comments · Fixed by #12443
Closed
Tracked by #7649

Define OpTxType #12333

emhane opened this issue Nov 5, 2024 · 3 comments · Fixed by #12443
Assignees
@ozgunozerk
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library

Comments

@emhane
Copy link
Member

emhane commented Nov 5, 2024 •
edited
Loading

Describe the feature

Define new type reth_optimism_primitives::OpTxType that implements reth_primitives_traits::TxType. This type is required because a Compact impl is needed on the deposit tx type. The type can simply be a wrapper of op_alloy_consensus::OpTxType.

This issue is blocked so long as reth_primitives_traits::TxType has From<alloy_consensus::TxType> as trait bound.

Additional context

No response
@emhane emhane added S-blocked This cannot more forward until something else changes A-sdk Related to reth's use as a library labels Nov 5, 2024
@emhane emhane added the A-op-reth Related to Optimism and op-reth label Nov 5, 2024
@Rjected
Copy link
Member

Rjected commented Nov 6, 2024

let's make an issue for removing the From bound

@emhane
Copy link
Member Author

emhane commented Nov 6, 2024

blocked by #12346

@ozgunozerk
Copy link
Contributor

I can volunteer for this one, feel free to assign it to me

@emhane emhane removed the S-blocked This cannot more forward until something else changes label Nov 10, 2024
@ozgunozerk ozgunozerk mentioned this issue Nov 11, 2024
Merged
@emhane emhane mentioned this issue Nov 11, 2024
Open
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozgunozerk ozgunozerk

Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(op): define OpTxType ozgunozerk/reth
3 participants
@Rjected @ozgunozerk @emhane