Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trait bound on TxType #12346

Closed
emhane opened this issue Nov 6, 2024 · 2 comments · Fixed by #12379
Closed

Remove trait bound on TxType #12346

emhane opened this issue Nov 6, 2024 · 2 comments · Fixed by #12379
Assignees
Labels
A-sdk Related to reth's use as a library D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Nov 6, 2024

Describe the feature

Remove trait bound From<alloy_consensus::TxType> off of

/// Trait representing the behavior of a transaction type.
pub trait TxType:
Into<u8>
+ Into<U8>
+ PartialEq
+ Eq
+ PartialEq<u8>
+ TryFrom<u8, Error = Eip2718Error>
+ TryFrom<u64>
+ TryFrom<U64>
+ From<alloy_consensus::TxType>
+ Debug
+ Display
+ Clone
+ Copy
+ Default
+ Encodable
+ Decodable
+ Send
+ Sync
+ 'static
{
}

Additional context

No response

@emhane emhane added D-good-first-issue Nice and easy! A great choice to get started A-sdk Related to reth's use as a library labels Nov 6, 2024
@ftupas
Copy link
Contributor

ftupas commented Nov 6, 2024

Hi may I take this one?

@Rjected
Copy link
Member

Rjected commented Nov 6, 2024

@ftupas assigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants