chore(sdk): add NodePrimitives::TxType
#12332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
C-debt
emhane
requested review from
mattsse,
Rjected,
fgimenez,
onbjerg,
joshieDo and
gakonst
as code owners
emhane
force-pushed
the
emhane/tx-type-node-primitives
branch
from
9a8e05e to
0139d93
Compare
Rjected
approved these changes
Nov 12, 2024
yes exactly the op feature will be removed by using op tx type in #12443 for op instead. also some additions to the tx type trait are incorporated into #12450. |
mattsse
approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #11531