Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Impl TransactionBuilder::complete_type for Optimism #27

Closed
emhane opened this issue Jul 28, 2024 · 2 comments · Fixed by #215
Closed

[Feature] Impl TransactionBuilder::complete_type for Optimism #27

emhane opened this issue Jul 28, 2024 · 2 comments · Fixed by #215
Assignees
@refcell
Labels
A-consensus Area: consensus crate

Comments

@emhane
Copy link
Member

emhane commented Jul 28, 2024

Component

rpc

Describe the feature you would like

Add type OpTransactionRequest that wraps a TransactionRequest. Implement method OpTransactionRequest::complete_deposit, for using in impl of TransactionBuilder::complete_type for Optimism.

Additional context

No response
This was referenced Jul 28, 2024
Open
Open
@emhane emhane mentioned this issue Sep 24, 2024
Open
3 tasks
@emhane emhane added A-consensus Area: consensus crate good-first-issue Issues that are easy to pick up for new contributors and removed good-first-issue Issues that are easy to pick up for new contributors labels Sep 24, 2024
@emhane
Copy link
Member Author

emhane commented Sep 24, 2024

@refcell would you be keen on this?

@refcell
Copy link
Collaborator

refcell commented Sep 24, 2024

@refcell would you be keen on this?

Certainly, I'll take a look later today!

@refcell refcell self-assigned this Sep 25, 2024
@klkvr klkvr mentioned this issue Oct 7, 2024
Merged
3 tasks
@klkvr klkvr mentioned this issue Nov 1, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 1, 2024
@klkvr
feat: OpTransactionRequest (#215)
b52866d 
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

Closes #27

To be able to replace `UnsingedTx` and `TxEnvelope` on Optimism network
with op-consensus types, we need a op-specific tx builder.

## Solution

Add `OpTransactionBuilder` which is a wrapper around
`TransactionBuilder`. It intentionally does not have any direct methods
allowing to set EIP-4844 fields, however they can still be set through
`AsMut` or during deserialization.

When building typed transaction, eip-4844 transactions are getting
converted to eip-1559

## PR Checklist

- [ ] Added Tests
- [ ] Added Documentation
- [ ] Breaking changes
@klkvr klkvr closed this as completed in #215 Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@refcell refcell

Labels
A-consensus Area: consensus crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: OpTransactionRequest alloy-rs/op-alloy
2 participants
@refcell @emhane